EDAC/amd64: Shut up an -Werror,-Wsometimes-uninitialized clang false positive
authorYazen Ghannam <yazen.ghannam@amd.com>
Tue, 14 Feb 2023 09:42:22 +0000 (10:42 +0100)
committerBorislav Petkov (AMD) <bp@alien8.de>
Tue, 14 Feb 2023 16:56:14 +0000 (17:56 +0100)
Reportedly, clang cannot do interprocedural analysis:

  https://lore.kernel.org/r/20230213-amd64_edac-wsometimes-uninitialized-v1-1-5bde32b89e02@kernel.org

and see that those arguments won't be used uninitialized.

So, yeah, the code's fine even without this. Normally, such a "fix"
won't be applied but that warning gets automatically enabled in -Wall
builds and when CONFIG_WERROR is set in allmodconfig builds, the build
fails.

So shut it up with a minimal fix as this code will see more
reorganization very soon.

  [ bp: Write commit message. ]

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/Y%2BqdVHidnrrKvxiD@dev-arch.thelio-3990X
drivers/edac/amd64_edac.c

index 1c4bef1..5b42533 100644 (file)
@@ -3928,7 +3928,7 @@ static const struct attribute_group *amd64_edac_attr_groups[] = {
 
 static int hw_info_get(struct amd64_pvt *pvt)
 {
-       u16 pci_id1, pci_id2;
+       u16 pci_id1 = 0, pci_id2 = 0;
        int ret;
 
        if (pvt->fam >= 0x17) {