soc: fsl: qe: fix sparse warnings for qe.c
authorLi Yang <leoyang.li@nxp.com>
Thu, 12 Mar 2020 20:28:49 +0000 (15:28 -0500)
committerLi Yang <leoyang.li@nxp.com>
Wed, 25 Mar 2020 00:02:22 +0000 (19:02 -0500)
Fixes the following sparse warnings:
drivers/soc/fsl/qe/qe.c:426:9: warning: cast to restricted __be32
drivers/soc/fsl/qe/qe.c:528:41: warning: incorrect type in assignment (different base types)
drivers/soc/fsl/qe/qe.c:528:41:    expected unsigned long long static [addressable] [toplevel] [usertype] extended_modes
drivers/soc/fsl/qe/qe.c:528:41:    got restricted __be64 const [usertype] extended_modes

Signed-off-by: Li Yang <leoyang.li@nxp.com>
drivers/soc/fsl/qe/qe.c

index 96c2057..4471468 100644 (file)
@@ -423,7 +423,7 @@ static void qe_upload_microcode(const void *base,
                qe_iowrite32be(be32_to_cpu(code[i]), &qe_immr->iram.idata);
        
        /* Set I-RAM Ready Register */
-       qe_iowrite32be(be32_to_cpu(QE_IRAM_READY), &qe_immr->iram.iready);
+       qe_iowrite32be(QE_IRAM_READY, &qe_immr->iram.iready);
 }
 
 /*
@@ -525,7 +525,7 @@ int qe_upload_firmware(const struct qe_firmware *firmware)
         */
        memset(&qe_firmware_info, 0, sizeof(qe_firmware_info));
        strlcpy(qe_firmware_info.id, firmware->id, sizeof(qe_firmware_info.id));
-       qe_firmware_info.extended_modes = firmware->extended_modes;
+       qe_firmware_info.extended_modes = be64_to_cpu(firmware->extended_modes);
        memcpy(qe_firmware_info.vtraps, firmware->vtraps,
                sizeof(firmware->vtraps));