pinctrl: aspeed: Fix confusing types in return value
authorJoel Stanley <joel@jms.id.au>
Thu, 19 Jan 2023 23:18:56 +0000 (09:48 +1030)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 27 Jan 2023 12:32:44 +0000 (13:32 +0100)
The function signature is int, but we return a bool. Instead return a
negative errno as the kerneldoc suggests.

Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs")
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Link: https://lore.kernel.org/r/20230119231856.52014-1-joel@jms.id.au
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/aspeed/pinctrl-aspeed.c

index 3945612..b5ca450 100644 (file)
@@ -114,7 +114,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx,
        int ret = 0;
 
        if (!exprs)
-               return true;
+               return -EINVAL;
 
        while (*exprs && !ret) {
                ret = aspeed_sig_expr_disable(ctx, *exprs);