staging: comedi: daqboard2000: Remove function db2k_initialize_dac()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Thu, 25 Jul 2019 05:23:59 +0000 (10:53 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2019 07:48:14 +0000 (09:48 +0200)
Remove function db2k_initialize_dac as all it does is call
db2k_dac_disarm.
Modify call site accordingly.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190725052359.2308-1-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/daqboard2000.c

index aabcda3..28603df 100644 (file)
@@ -665,11 +665,6 @@ static void db2k_initialize_adc(struct comedi_device *dev)
        db2k_initialize_tmrs(dev);
 }
 
-static void db2k_initialize_dac(struct comedi_device *dev)
-{
-       db2k_dac_disarm(dev);
-}
-
 static int db2k_8255_cb(struct comedi_device *dev, int dir, int port, int data,
                        unsigned long iobase)
 {
@@ -719,7 +714,7 @@ static int db2k_auto_attach(struct comedi_device *dev, unsigned long context)
                return result;
 
        db2k_initialize_adc(dev);
-       db2k_initialize_dac(dev);
+       db2k_dac_disarm(dev);
 
        s = &dev->subdevices[0];
        /* ai subdevice */