anv: remove CS_FLUSH from query regression

Fixes performance regression introduced by prior refactoring of
pipe control code that unnecessarily added CS_FLUSH to query start
and end. Issue was diagnosed by Ben L (thank you!)

Confirmed this restores performance on:
* Borderlands3 +2%
* Payday +3%
* Factorio +3%
* HogwartsLegacy +4%
* Ghostrunner +7%

Fixes: 6dc95685 (convert genX_query pipe controls to use pc helper)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25983>
(cherry picked from commit aa23120e4fc674d7da42c4895aa204f300155105)

diff --git a/.pick_status.json b/.pick_status.json
index 401ec80..e9283e2 100644 (file)
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -1694,7 +1694,7 @@
         "description": "anv: remove CS_FLUSH from query regression",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "6dc95685f3b1a14b2a0d80bc05ea198de8027f44",
         "notes": null

diff --git a/src/intel/vulkan/genX_query.c b/src/intel/vulkan/genX_query.c
index f42298f..69c5ac8 100644 (file)
--- a/src/intel/vulkan/genX_query.c
+++ b/src/intel/vulkan/genX_query.c
@@ -695,7 +695,7 @@ emit_query_pc_availability(struct anv_cmd_buffer *cmd_buffer,
 
    genx_batch_emit_pipe_control_write
       (&cmd_buffer->batch, cmd_buffer->device->info, WriteImmediateData, addr,
-       available, ANV_PIPE_CS_STALL_BIT);
+       available, 0);
 }
 
 /**