media: platform: Delete zeroing the reserved fields
authorXia Jiang <xia.jiang@mediatek.com>
Fri, 14 Aug 2020 07:11:44 +0000 (09:11 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 28 Aug 2020 13:28:08 +0000 (15:28 +0200)
Delete zeroing the reserved fields because that the core already
does it.

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c

index 63f734d..37156af 100644 (file)
@@ -198,7 +198,6 @@ static int mtk_jpeg_try_fmt_mplane(struct v4l2_format *f,
        struct mtk_jpeg_dev *jpeg = ctx->jpeg;
        int i;
 
-       memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
        pix_mp->field = V4L2_FIELD_NONE;
 
        if (ctx->state != MTK_JPEG_INIT) {
@@ -217,7 +216,6 @@ static int mtk_jpeg_try_fmt_mplane(struct v4l2_format *f,
                                           &pix_mp->height, MTK_JPEG_MIN_HEIGHT,
                                           MTK_JPEG_MAX_HEIGHT, 0);
 
-               memset(pfmt->reserved, 0, sizeof(pfmt->reserved));
                pfmt->bytesperline = 0;
                /* Source size must be aligned to 128 */
                pfmt->sizeimage = mtk_jpeg_align(pfmt->sizeimage, 128);
@@ -237,7 +235,6 @@ static int mtk_jpeg_try_fmt_mplane(struct v4l2_format *f,
                u32 stride = pix_mp->width * fmt->h_sample[i] / 4;
                u32 h = pix_mp->height * fmt->v_sample[i] / 4;
 
-               memset(pfmt->reserved, 0, sizeof(pfmt->reserved));
                pfmt->bytesperline = stride;
                pfmt->sizeimage = stride * h;
        }
@@ -270,7 +267,6 @@ static int mtk_jpeg_g_fmt_vid_mplane(struct file *file, void *priv,
 
        q_data = mtk_jpeg_get_q_data(ctx, f->type);
 
-       memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
        pix_mp->width = q_data->w;
        pix_mp->height = q_data->h;
        pix_mp->field = V4L2_FIELD_NONE;
@@ -294,7 +290,6 @@ static int mtk_jpeg_g_fmt_vid_mplane(struct file *file, void *priv,
 
                pfmt->bytesperline = q_data->bytesperline[i];
                pfmt->sizeimage = q_data->sizeimage[i];
-               memset(pfmt->reserved, 0, sizeof(pfmt->reserved));
 
                v4l2_dbg(1, debug, &jpeg->v4l2_dev,
                         "plane[%d] bpl=%u, size=%u\n",