platform/x86: intel_pmc_core: Change driver to a module
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Thu, 11 Jan 2018 11:10:34 +0000 (16:40 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 16 Jan 2018 15:24:15 +0000 (17:24 +0200)
Allow the driver to be a module since builtin_pci_driver funtionality is no
longer needed.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/Kconfig
drivers/platform/x86/intel_pmc_core.c

index de51952..1c251eb 100644 (file)
@@ -974,7 +974,7 @@ config INTEL_IMR
          If you are running on a Galileo/Quark say Y here.
 
 config INTEL_PMC_CORE
-       bool "Intel PMC Core driver"
+       tristate "Intel PMC Core driver"
        depends on PCI
        ---help---
          The Intel Platform Controller Hub for Intel Core SoCs provides access
index 0074847..4435303 100644 (file)
@@ -21,8 +21,8 @@
 #include <linux/debugfs.h>
 #include <linux/delay.h>
 #include <linux/device.h>
-#include <linux/init.h>
 #include <linux/io.h>
+#include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/uaccess.h>
 
@@ -124,6 +124,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
                                        (kernel_ulong_t)&spt_reg_map },
        { 0, },
 };
+MODULE_DEVICE_TABLE(pci, pmc_pci_ids);
 
 static inline u8 pmc_core_reg_read_byte(struct pmc_dev *pmcdev, int offset)
 {
@@ -520,10 +521,20 @@ static int pmc_core_probe(struct pci_dev *dev, const struct pci_device_id *id)
        return 0;
 }
 
+static void pmc_core_remove(struct pci_dev *dev)
+{
+       pmc_core_dbgfs_unregister(&pmc);
+       mutex_destroy(&pmc.lock);
+}
+
 static struct pci_driver intel_pmc_core_driver = {
        .name = "intel_pmc_core",
        .id_table = pmc_pci_ids,
        .probe = pmc_core_probe,
+       .remove = pmc_core_remove,
 };
 
-builtin_pci_driver(intel_pmc_core_driver);
+module_pci_driver(intel_pmc_core_driver);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Intel PMC Core Driver");