ui_application: Delete terminate callback. 55/206955/7 accepted/tizen/unified/20190603.095339 accepted/tizen/unified/20190604.014641 submit/tizen/20190530.111225 submit/tizen/20190531.122943 submit/tizen/20190603.083549
authorWoochanlee <wc0917.lee@samsung.com>
Wed, 29 May 2019 09:27:26 +0000 (18:27 +0900)
committerWoochanlee <wc0917.lee@samsung.com>
Wed, 29 May 2019 11:05:47 +0000 (20:05 +0900)
TFDF-1805

The ui_app_capi class already deleted when UI_APPLICATION_EVENT_TERMINATE callback called.

Change-Id: I58f542b85a6ec9bff0f6a02ad3abb9df0ff009be

src/include/efl/mobile/c/ui_application.h
src/lib/efl/mobile/c/ui_application.cpp

index 630a63165906fc4b38dce3cdbc52a5bd8bf839db..de9c9248783ef53ef8d543c74c401c75995ba030 100644 (file)
@@ -36,6 +36,7 @@ typedef bool (*ui_application_event_cb)(void *user_data, void *event_info);
  */
 typedef enum {
        UI_APPLICATION_EVENT_CREATE = 0,      /**< App create */
+       //FIXME: Terminate callback is not calling now.
        UI_APPLICATION_EVENT_TERMINATE,       /**< App terminate */
        UI_APPLICATION_EVENT_PAUSE ,          /**< App pause */
        UI_APPLICATION_EVENT_RESUME,          /**< App resume */
index 353a97665068793e7d35dd7b1e4dffccfcfcc961..c5100bf26ce670ba1abd95954876fbf15d81b396 100644 (file)
@@ -35,10 +35,13 @@ public:
 
                UiApp::onTerminate();
 
+               /* FIXME: Heap use after free occured below.
+                         ui_app_capi class will be deleted when UiApp::onTerminate() called.
                if (this->event_cb[UI_APPLICATION_EVENT_TERMINATE])
                {
                        this->event_cb[UI_APPLICATION_EVENT_TERMINATE](this->user_data[UI_APPLICATION_EVENT_TERMINATE], nullptr);
                }
+               */
        }
 
        void onPause() override