devlink: remove unnecessary parameter from chunk_fill function

The devlink parameter of the devlink_nl_cmd_region_read_chunk_fill
function is not used. Remove it, to simplify the function signature.

Once removed, it is also obvious that the devlink parameter is not
necessary for the devlink_nl_region_read_snapshot_fill either.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/core/devlink.c b/net/core/devlink.c
index e3166c9..5b8a9bd 100644 (file)
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -6431,7 +6431,6 @@ unlock:
 }
 
 static int devlink_nl_cmd_region_read_chunk_fill(struct sk_buff *msg,
-                                                struct devlink *devlink,
                                                 u8 *chunk, u32 chunk_size,
                                                 u64 addr)
 {
@@ -6462,7 +6461,6 @@ nla_put_failure:
 #define DEVLINK_REGION_READ_CHUNK_SIZE 256
 
 static int devlink_nl_region_read_snapshot_fill(struct sk_buff *skb,
-                                               struct devlink *devlink,
                                                struct devlink_snapshot *snapshot,
                                                u64 start_offset,
                                                u64 end_offset,
@@ -6481,9 +6479,7 @@ static int devlink_nl_region_read_snapshot_fill(struct sk_buff *skb,
                                  DEVLINK_REGION_READ_CHUNK_SIZE);
 
                data = &snapshot->data[curr_offset];
-               err = devlink_nl_cmd_region_read_chunk_fill(skb, devlink,
-                                                           data, data_size,
-                                                           curr_offset);
+               err = devlink_nl_cmd_region_read_chunk_fill(skb, data, data_size, curr_offset);
                if (err)
                        break;
 
@@ -6612,9 +6608,7 @@ static int devlink_nl_cmd_region_read_dumpit(struct sk_buff *skb,
                goto nla_put_failure;
        }
 
-       err = devlink_nl_region_read_snapshot_fill(skb, devlink,
-                                                  snapshot,
-                                                  start_offset,
+       err = devlink_nl_region_read_snapshot_fill(skb, snapshot, start_offset,
                                                   end_offset, &ret_offset);
 
        if (err && err != -EMSGSIZE)