KVM: x86/mmu: Remove superfluous gotos from mmu_topup_memory_caches()
authorSean Christopherson <sean.j.christopherson@intel.com>
Fri, 3 Jul 2020 02:35:28 +0000 (19:35 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 9 Jul 2020 17:29:38 +0000 (13:29 -0400)
Return errors directly from mmu_topup_memory_caches() instead of
branching to a label that does the same.

No functional change intended.

Reviewed-by: Ben Gardon <bgardon@google.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Message-Id: <20200703023545.8771-5-sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/mmu.c

index 26f0c82..7fae1c3 100644 (file)
@@ -1101,13 +1101,11 @@ static int mmu_topup_memory_caches(struct kvm_vcpu *vcpu)
        r = mmu_topup_memory_cache(&vcpu->arch.mmu_pte_list_desc_cache,
                                   8 + PTE_PREFETCH_NUM);
        if (r)
-               goto out;
+               return r;
        r = mmu_topup_memory_cache(&vcpu->arch.mmu_page_cache, 8);
        if (r)
-               goto out;
-       r = mmu_topup_memory_cache(&vcpu->arch.mmu_page_header_cache, 4);
-out:
-       return r;
+               return r;
+       return mmu_topup_memory_cache(&vcpu->arch.mmu_page_header_cache, 4);
 }
 
 static void mmu_free_memory_caches(struct kvm_vcpu *vcpu)