NFS: Use kzalloc() to avoid initialising the nfs_open_dir_context
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 22 Feb 2022 17:10:36 +0000 (12:10 -0500)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 28 Feb 2022 15:11:32 +0000 (10:11 -0500)
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/dir.c

index 1dfbd05..379f88b 100644 (file)
@@ -69,18 +69,15 @@ const struct address_space_operations nfs_dir_aops = {
        .freepage = nfs_readdir_clear_array,
 };
 
-static struct nfs_open_dir_context *alloc_nfs_open_dir_context(struct inode *dir)
+static struct nfs_open_dir_context *
+alloc_nfs_open_dir_context(struct inode *dir)
 {
        struct nfs_inode *nfsi = NFS_I(dir);
        struct nfs_open_dir_context *ctx;
-       ctx = kmalloc(sizeof(*ctx), GFP_KERNEL_ACCOUNT);
+
+       ctx = kzalloc(sizeof(*ctx), GFP_KERNEL_ACCOUNT);
        if (ctx != NULL) {
-               ctx->duped = 0;
                ctx->attr_gencount = nfsi->attr_gencount;
-               ctx->dir_cookie = 0;
-               ctx->dup_cookie = 0;
-               ctx->page_index = 0;
-               ctx->eof = false;
                spin_lock(&dir->i_lock);
                if (list_empty(&nfsi->open_files) &&
                    (nfsi->cache_validity & NFS_INO_DATA_INVAL_DEFER))