staging: vchiq: delete obselete comment
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 5 Jan 2021 13:19:14 +0000 (16:19 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Jan 2021 14:27:22 +0000 (15:27 +0100)
This comment describes a security problem which was fixed in commit
1c954540c0eb ("staging: vchiq: avoid mixing kernel and user pointers").
The bug is fixed now so the FIXME can be removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X/RnUjY3XkZohk7w@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index f500a70..54770a9 100644 (file)
@@ -999,13 +999,6 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance,
                userdata = &waiter->bulk_waiter;
        }
 
-       /*
-        * FIXME address space mismatch:
-        * args->data may be interpreted as a kernel pointer
-        * in create_pagelist() called from vchiq_bulk_transfer(),
-        * accessing kernel data instead of user space, based on the
-        * address.
-        */
        status = vchiq_bulk_transfer(args->handle, NULL, args->data, args->size,
                                     userdata, args->mode, dir);