crypto: atmel-{aes,tdes} - Update the IV only when the op succeeds
authorTudor Ambarus <tudor.ambarus@microchip.com>
Fri, 13 Dec 2019 09:54:56 +0000 (09:54 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 20 Dec 2019 06:58:35 +0000 (14:58 +0800)
Do not update the IV in case of errors.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/atmel-aes.c
drivers/crypto/atmel-tdes.c

index 855f0cc..245d45f 100644 (file)
@@ -546,7 +546,7 @@ static inline int atmel_aes_complete(struct atmel_aes_dev *dd, int err)
        clk_disable(dd->iclk);
        dd->flags &= ~AES_FLAGS_BUSY;
 
-       if (!dd->ctx->is_aead &&
+       if (!err && !dd->ctx->is_aead &&
            (rctx->mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_ECB) {
                if ((rctx->mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_CTR)
                        atmel_aes_set_iv_as_last_ciphertext_block(dd);
index 83a6d42..e7cd7b0 100644 (file)
@@ -597,7 +597,7 @@ static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
 
        dd->flags &= ~TDES_FLAGS_BUSY;
 
-       if ((rctx->mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB)
+       if (!err && (rctx->mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB)
                atmel_tdes_set_iv_as_last_ciphertext_block(dd);
 
        req->base.complete(&req->base, err);