tests: more precise negative check for dnsmasq log (#4982)
authorMartin Pitt <martin.pitt@ubuntu.com>
Mon, 26 Dec 2016 11:19:25 +0000 (12:19 +0100)
committerLennart Poettering <lennart@poettering.net>
Mon, 26 Dec 2016 11:19:25 +0000 (12:19 +0100)
In test_resolved_domain_restricted_dns(), add dot domain separator to
negative .lab/.company tests, so that we don't catch these as part of
the host name (like "lxc-labjfr").

Caught in PR #4962

test/networkd-test.py

index f178a14..8599398 100755 (executable)
@@ -497,8 +497,8 @@ Domains= ~company ~lab''')
         # VPN domains should only be sent to VPN DNS
         self.assertRegex(vpn_log, 'query.*math.lab')
         self.assertRegex(vpn_log, 'query.*cantina.company')
-        self.assertNotIn('lab', general_log)
-        self.assertNotIn('company', general_log)
+        self.assertNotIn('.lab', general_log)
+        self.assertNotIn('.company', general_log)
 
         # general domains should not be sent to the VPN DNS
         self.assertRegex(general_log, 'query.*megasearch.net')