device property: Drop redundant NULL checks
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 26 Oct 2021 16:29:54 +0000 (19:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Oct 2021 17:14:01 +0000 (19:14 +0200)
In cases when functions are called via fwnode operations,
we already know that this is software node we are dealing
with, hence no need to check if it's NULL, it can't be,

Reported-by: YE Chengfeng <cyeaa@connect.ust.hk>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211026162954.89811-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/swnode.c

index c46f6a8..4debcea 100644 (file)
@@ -413,9 +413,6 @@ software_node_get_name(const struct fwnode_handle *fwnode)
 {
        const struct swnode *swnode = to_swnode(fwnode);
 
-       if (!swnode)
-               return "(null)";
-
        return kobject_name(&swnode->kobj);
 }
 
@@ -507,9 +504,6 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
        int error;
        int i;
 
-       if (!swnode)
-               return -ENOENT;
-
        prop = property_entry_get(swnode->node->properties, propname);
        if (!prop)
                return -ENOENT;