projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f2e13d2
)
gpio: tc3589x: Be sure to clamp return value
author
Linus Walleij
<linus.walleij@linaro.org>
Mon, 21 Dec 2015 10:42:30 +0000
(11:42 +0100)
committer
Linus Walleij
<linus.walleij@linaro.org>
Sat, 26 Dec 2015 21:28:25 +0000
(22:28 +0100)
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-tc3589x.c
patch
|
blob
|
history
diff --git
a/drivers/gpio/gpio-tc3589x.c
b/drivers/gpio/gpio-tc3589x.c
index
7c1537e
..
2896aef
100644
(file)
--- a/
drivers/gpio/gpio-tc3589x.c
+++ b/
drivers/gpio/gpio-tc3589x.c
@@
-51,7
+51,7
@@
static int tc3589x_gpio_get(struct gpio_chip *chip, unsigned offset)
if (ret < 0)
return ret;
- return
ret & mask
;
+ return
!!(ret & mask)
;
}
static void tc3589x_gpio_set(struct gpio_chip *chip, unsigned offset, int val)