HID: wacom: Delete an unnecessary check before kobject_put()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 6 Nov 2015 17:00:30 +0000 (18:00 +0100)
committerJiri Kosina <jkosina@suse.cz>
Thu, 19 Nov 2015 15:52:31 +0000 (16:52 +0100)
The kobject_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/wacom_sys.c

index e06af5b..c7a3b79 100644 (file)
@@ -1353,8 +1353,7 @@ static void wacom_clean_inputs(struct wacom *wacom)
                else
                        input_free_device(wacom->wacom_wac.pad_input);
        }
-       if (wacom->remote_dir)
-               kobject_put(wacom->remote_dir);
+       kobject_put(wacom->remote_dir);
        wacom->wacom_wac.pen_input = NULL;
        wacom->wacom_wac.touch_input = NULL;
        wacom->wacom_wac.pad_input = NULL;