drm/client: Switch drm_client_buffer_delete() to unlocked drm_gem_vunmap
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Thu, 20 Oct 2022 21:33:35 +0000 (00:33 +0300)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Mon, 24 Oct 2022 19:05:43 +0000 (22:05 +0300)
The drm_client_buffer_delete() wasn't switched to unlocked GEM vunmapping
by accident when rest of drm_client code transitioned to the unlocked
variants of the vmapping functions. Make drm_client_buffer_delete() use
the unlocked variant. This fixes lockdep warning splat about missing
reservation lock when framebuffer is released.

Reported-by: kernel test robot <yujie.liu@intel.com>
Link: https://lore.kernel.org/dri-devel/890f70db-68b0-8456-ca3c-c5496ef90517@collabora.com/T/
Fixes: 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations")
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Acked-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221020213335.309092-1-dmitry.osipenko@collabora.com
drivers/gpu/drm/drm_client.c

index fbcb1e9..38e1be9 100644 (file)
@@ -235,7 +235,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer)
 {
        struct drm_device *dev = buffer->client->dev;
 
-       drm_gem_vunmap(buffer->gem, &buffer->map);
+       drm_gem_vunmap_unlocked(buffer->gem, &buffer->map);
 
        if (buffer->gem)
                drm_gem_object_put(buffer->gem);