mips: kernel: convert to DEFINE_SHOW_ATTRIBUTE
authorLiu Shixin <liushixin2@huawei.com>
Tue, 13 Sep 2022 10:10:37 +0000 (18:10 +0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Mon, 19 Sep 2022 14:40:17 +0000 (16:40 +0200)
Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.

Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kernel/segment.c

index 0a9bd7b..2456050 100644 (file)
@@ -46,7 +46,7 @@ static void build_segment_config(char *str, unsigned int cfg)
                ((cfg & MIPS_SEGCFG_EU) >> MIPS_SEGCFG_EU_SHIFT));
 }
 
-static int show_segments(struct seq_file *m, void *v)
+static int segments_show(struct seq_file *m, void *v)
 {
        unsigned int segcfg;
        char str[42];
@@ -80,18 +80,7 @@ static int show_segments(struct seq_file *m, void *v)
 
        return 0;
 }
-
-static int segments_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, show_segments, NULL);
-}
-
-static const struct file_operations segments_fops = {
-       .open           = segments_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(segments);
 
 static int __init segments_info(void)
 {