dm ioctl: have constant on the right side of the test
authorHeinz Mauelshagen <heinzm@redhat.com>
Tue, 7 Feb 2023 20:47:45 +0000 (21:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:22:07 +0000 (16:22 +0200)
[ Upstream commit 5cae0aa77397015f530aeb34f3ced32db6ac2875 ]

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Stable-dep-of: 249bed821b4d ("dm ioctl: Avoid double-fetch of version")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/md/dm-ioctl.c

index 2ced382..6aeae09 100644 (file)
@@ -1819,8 +1819,8 @@ static int check_version(unsigned int cmd, struct dm_ioctl __user *user)
        if (copy_from_user(version, user->version, sizeof(version)))
                return -EFAULT;
 
-       if ((DM_VERSION_MAJOR != version[0]) ||
-           (DM_VERSION_MINOR < version[1])) {
+       if ((version[0] != DM_VERSION_MAJOR) ||
+           (version[1] > DM_VERSION_MINOR)) {
                DMERR("ioctl interface mismatch: kernel(%u.%u.%u), user(%u.%u.%u), cmd(%d)",
                      DM_VERSION_MAJOR, DM_VERSION_MINOR,
                      DM_VERSION_PATCHLEVEL,