weston-launcher: use CLOEXEC on fallback path
authorPekka Paalanen <ppaalanen@gmail.com>
Tue, 31 Jul 2012 10:21:06 +0000 (13:21 +0300)
committerKristian Høgsberg <krh@bitplanet.net>
Wed, 1 Aug 2012 02:19:31 +0000 (22:19 -0400)
If there is no weston-launcher available, launcher-util.c will fall back
to opening the given file itself. It that case it does not set the
close-on-exec flag, and will presumably leak the file descriptor to
children.

Use O_CLOEXEC on the fallback path, too.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
src/launcher-util.c

index ad03c1d..b4b82f1 100644 (file)
@@ -54,7 +54,7 @@ weston_launcher_open(struct weston_compositor *compositor,
        struct weston_launcher_open *message;
 
        if (sock == -1)
-               return open(path, flags);
+               return open(path, flags | O_CLOEXEC);
 
        n = sizeof(*message) + strlen(path) + 1;
        message = malloc(n);