Revert "Suppress -Wctad-maybe-unsupported on types w/o deduction guides."
authorEric Fiselier <eric@efcs.ca>
Sun, 4 Aug 2019 07:13:43 +0000 (07:13 +0000)
committerEric Fiselier <eric@efcs.ca>
Sun, 4 Aug 2019 07:13:43 +0000 (07:13 +0000)
Some modules builds are issuing buggy diagnostics. The cause of which is
TBD.

This reverts commit r@367770.

llvm-svn: 367777

libcxx/include/__config
libcxx/include/__mutex_base
libcxx/include/functional
libcxx/include/iterator
libcxx/include/mutex
libcxx/include/shared_mutex
libcxx/include/string_view
libcxx/test/std/iterators/predef.iterators/insert.iterators/back.insert.iterator/implicit_ctad.pass.cpp [deleted file]
libcxx/utils/libcxx/test/config.py

index a8991c3..e49adb4 100644 (file)
@@ -1429,15 +1429,6 @@ _LIBCPP_FUNC_VIS extern "C" void __sanitizer_annotate_contiguous_container(
 
 #define _LIBCPP_UNUSED_VAR(x) ((void)(x))
 
-#ifndef _LIBCPP_HAS_NO_DEDUCTION_GUIDES
-#define _LIBCPP_CTAD_SUPPORTED_FOR_TYPE(_ClassName) \
-  template <class _Tag = void> \
-  _ClassName(typename _Tag::__allow_ctad) -> _ClassName<void>
-#else
-#define _LIBCPP_CTAD_SUPPORTED_FOR_TYPE(_ClassName) \
-   static_assert(true, "")
-#endif // _LIBCPP_HAS_NO_DEDUCTION_GUIDES
-
 #endif // __cplusplus
 
 #endif // _LIBCPP_CONFIG
index 6361c20..f828bea 100644 (file)
@@ -107,8 +107,6 @@ private:
     lock_guard(lock_guard const&) _LIBCPP_EQUAL_DELETE;
     lock_guard& operator=(lock_guard const&) _LIBCPP_EQUAL_DELETE;
 };
-_LIBCPP_CTAD_SUPPORTED_FOR_TYPE(lock_guard);
-
 
 template <class _Mutex>
 class _LIBCPP_TEMPLATE_VIS unique_lock
@@ -207,7 +205,6 @@ public:
     _LIBCPP_INLINE_VISIBILITY
     mutex_type* mutex() const _NOEXCEPT {return __m_;}
 };
-_LIBCPP_CTAD_SUPPORTED_FOR_TYPE(unique_lock);
 
 template <class _Mutex>
 void
index dd65f1b..865a281 100644 (file)
@@ -3067,8 +3067,7 @@ private:
     _ForwardIterator __first_;
     _ForwardIterator __last_;
     _BinaryPredicate __pred_;
-};
-_LIBCPP_CTAD_SUPPORTED_FOR_TYPE(default_searcher);
+    };
 
 #endif // _LIBCPP_STD_VER > 14
 
index b503f15..30801ea 100644 (file)
@@ -841,7 +841,6 @@ public:
     _LIBCPP_INLINE_VISIBILITY back_insert_iterator& operator++()    {return *this;}
     _LIBCPP_INLINE_VISIBILITY back_insert_iterator  operator++(int) {return *this;}
 };
-_LIBCPP_CTAD_SUPPORTED_FOR_TYPE(back_insert_iterator);
 
 template <class _Container>
 inline _LIBCPP_INLINE_VISIBILITY
index a7d6232..20c3ffc 100644 (file)
@@ -546,7 +546,6 @@ private:
 
     _MutexTuple __t_;
 };
-_LIBCPP_CTAD_SUPPORTED_FOR_TYPE(scoped_lock);
 
 #endif // _LIBCPP_STD_VER > 14
 #endif // !_LIBCPP_HAS_NO_THREADS
index c991134..fcafd8c 100644 (file)
@@ -430,7 +430,6 @@ public:
     _LIBCPP_INLINE_VISIBILITY
     mutex_type* mutex() const _NOEXCEPT {return __m_;}
 };
-_LIBCPP_CTAD_SUPPORTED_FOR_TYPE(shared_lock);
 
 template <class _Mutex>
 void
index 39ebc66..0444831 100644 (file)
@@ -604,7 +604,6 @@ private:
     const   value_type* __data;
     size_type           __size;
 };
-_LIBCPP_CTAD_SUPPORTED_FOR_TYPE(basic_string_view);
 
 
 // [string.view.comparison]
diff --git a/libcxx/test/std/iterators/predef.iterators/insert.iterators/back.insert.iterator/implicit_ctad.pass.cpp b/libcxx/test/std/iterators/predef.iterators/insert.iterators/back.insert.iterator/implicit_ctad.pass.cpp
deleted file mode 100644 (file)
index 7c4ba6a..0000000
+++ /dev/null
@@ -1,41 +0,0 @@
-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// <iterator>
-
-// UNSUPPORTED: c++98, c++03, c++11, c++14
-// UNSUPPORTED: libcpp-no-deduction-guides
-
-// class back_insert_iterator.
-
-#include <string>
-#include <iterator>
-#include <vector>
-#include <cassert>
-#include <cstddef>
-#include <functional>
-
-#include "test_macros.h"
-
-int main(int, char**)
-{
-    {
-      std::string s;
-      std::back_insert_iterator bs(s);
-      ASSERT_SAME_TYPE(decltype(bs), std::back_insert_iterator<std::string>);
-    }
-  {
-    std::vector<int> v;
-    std::back_insert_iterator bv(v);
-    std::back_insert_iterator cp(bv);
-    ASSERT_SAME_TYPE(decltype(bv), std::back_insert_iterator<std::vector<int>>);
-    ASSERT_SAME_TYPE(decltype(cp), std::back_insert_iterator<std::vector<int>>);
-  }
-
-  return 0;
-}
index 6552d30..82951b7 100644 (file)
@@ -911,7 +911,6 @@ class Configuration(object):
         self.cxx.addWarningFlagIfSupported('-Wunused-variable')
         self.cxx.addWarningFlagIfSupported('-Wunused-parameter')
         self.cxx.addWarningFlagIfSupported('-Wunreachable-code')
-        self.cxx.addWarningFlagIfSupported('-Wctad-maybe-unsupported')
         std = self.get_lit_conf('std', None)
         if std in ['c++98', 'c++03']:
             # The '#define static_assert' provided by libc++ in C++03 mode