media: ccs: Correctly initialise try compose rectangle
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 4 Sep 2023 12:57:37 +0000 (15:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:20:12 +0000 (17:20 +0000)
commit 724ff68e968b19d786870d333f9952bdd6b119cb upstream.

Initialise the try sink compose rectangle size to the sink compose
rectangle for binner and scaler sub-devices. This was missed due to the
faulty condition that lead to the compose rectangles to be initialised for
the pixel array sub-device where it is not relevant.

Fixes: ccfc97bdb5ae ("[media] smiapp: Add driver")
Cc: stable@vger.kernel.org
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/i2c/ccs/ccs-core.c

index 49e0d9a..6f8fbd8 100644 (file)
@@ -3097,7 +3097,7 @@ static int ccs_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
                try_fmt->code = sensor->internal_csi_format->code;
                try_fmt->field = V4L2_FIELD_NONE;
 
-               if (ssd != sensor->pixel_array)
+               if (ssd == sensor->pixel_array)
                        continue;
 
                try_comp = v4l2_subdev_get_try_compose(sd, fh->state, i);