re PR middle-end/28403 (Missed argument pop after doubleword shift)

gcc/
	PR middle-end/28403
	* optabs.c (expand_doubleword_shift): Wrap the call to
	do_compare_rtx_and_jump with NO_DEFER_POP and OK_DEFER_POP.

gcc/testsuite/
	PR middle-end/28403
	* gcc.c-torture/execute/pr28403.c: New test.

From-SVN: r115525

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index e9dba8e..7a7b79f 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,11 @@
 2006-07-17  Richard Sandiford  <richard@codesourcery.com>
 
+       PR middle-end/28403
+       * optabs.c (expand_doubleword_shift): Wrap the call to
+       do_compare_rtx_and_jump with NO_DEFER_POP and OK_DEFER_POP.
+
+2006-07-17  Richard Sandiford  <richard@codesourcery.com>
+
        PR middle-end/28402
        * optabs.c (expand_binop): Pass next_methods rather than methods
        to expand_doubleword_shift.

diff --git a/gcc/optabs.c b/gcc/optabs.c
index a8be6f9..fe7ae06 100644 (file)
--- a/gcc/optabs.c
+++ b/gcc/optabs.c
@@ -959,8 +959,10 @@ expand_doubleword_shift (enum machine_mode op1_mode, optab binoptab,
   subword_label = gen_label_rtx ();
   done_label = gen_label_rtx ();
 
+  NO_DEFER_POP;
   do_compare_rtx_and_jump (cmp1, cmp2, cmp_code, false, op1_mode,
                           0, 0, subword_label);
+  OK_DEFER_POP;
 
   if (!expand_superword_shift (binoptab, outof_input, superword_op1,
                               outof_target, into_target,

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index e79fd29..a9398a3 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,10 @@
 2006-07-17  Richard Sandiford  <richard@codesourcery.com>
 
+       PR middle-end/28403
+       * gcc.c-torture/execute/pr28403.c: New test.
+
+2006-07-17  Richard Sandiford  <richard@codesourcery.com>
+
        PR middle-end/28402
        * gcc.dg/pr28402.c: New test.
 

diff --git a/gcc/testsuite/gcc.c-torture/execute/pr28403.c b/gcc/testsuite/gcc.c-torture/execute/pr28403.c
new file mode 100644 (file)
index 0000000..8f85ea0
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/execute/pr28403.c
@@ -0,0 +1,23 @@
+typedef unsigned long long ull;
+int global;
+
+int __attribute__((noinline))
+foo (int x1, int x2, int x3, int x4, int x5, int x6, int x7, int x8)
+{
+  global = x1 + x2 + x3 + x4 + x5 + x6 + x7 + x8;
+}
+
+ull __attribute__((noinline))
+bar (ull x)
+{
+  foo (1, 2, 1, 3, 1, 4, 1, 5);
+  return x >> global;
+}
+
+int
+main (void)
+{
+  if (bar (0x123456789abcdefULL) != (0x123456789abcdefULL >> 18))
+    abort ();
+  exit (0);
+}