Multiview: do not use inline renderpass with secondary command buffers
authorSlawomir Cygan <slawomir.cygan@intel.com>
Wed, 18 Apr 2018 13:14:23 +0000 (15:14 +0200)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Fri, 11 May 2018 11:50:02 +0000 (07:50 -0400)
There is a regression introduced in 7b76766 alongside the new render
pass begin utility:

The new utility sets the render pass contents flag to 'INLINE' by
default. This was overlooked in some multiview tests cases, which use
secondary command buffers - the default should be overriden to
'SECONDARY_COMMAND_BUFFERS'.

Components: Vulkan

VK-GL-CTS Issue: 1133

Affects:
dEQP-VK.multiview.secondary_cmd_buffer_geometry
dEQP-VK.multiview.secondary_cmd_buffer

Change-Id: Ibe42ba4c3e6d2b43ed18ac3684ba480f9dc659a8

external/vulkancts/modules/vulkan/multiview/vktMultiViewRenderTests.cpp

index 9e1b2ee..aab9d7d 100644 (file)
@@ -1918,7 +1918,7 @@ void MultiViewSecondaryCommandBufferTestInstance::draw (const deUint32 subpassCo
 
        beforeDraw();
 
-       beginRenderPass(*m_device, *m_cmdBuffer, renderPass, frameBuffer, makeRect2D(0, 0, m_parameters.extent.width, m_parameters.extent.height), tcu::Vec4(0.0f));
+       beginRenderPass(*m_device, *m_cmdBuffer, renderPass, frameBuffer, makeRect2D(0, 0, m_parameters.extent.width, m_parameters.extent.height), tcu::Vec4(0.0f), VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS);
 
        //Create secondary buffer
        const VkCommandBufferAllocateInfo       cmdBufferAllocateInfo   =