projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dc30b40
)
net_sched: sch_skbprio: add message validation to skbprio_change()
author
Eric Dumazet
<edumazet@google.com>
Sun, 3 May 2020 03:09:25 +0000
(20:09 -0700)
committer
David S. Miller
<davem@davemloft.net>
Sun, 3 May 2020 22:52:13 +0000
(15:52 -0700)
Do not assume the attribute has the right size.
Fixes: aea5f654e6b7 ("net/sched: add skbprio scheduler")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_skbprio.c
patch
|
blob
|
history
diff --git
a/net/sched/sch_skbprio.c
b/net/sched/sch_skbprio.c
index 0fb10abf757962c1e3e6feb8c68dedd9a1808f1b..7a5e4c454715617cb57c6db7de7fdaa9e6886d40 100644
(file)
--- a/
net/sched/sch_skbprio.c
+++ b/
net/sched/sch_skbprio.c
@@
-169,6
+169,9
@@
static int skbprio_change(struct Qdisc *sch, struct nlattr *opt,
{
struct tc_skbprio_qopt *ctl = nla_data(opt);
+ if (opt->nla_len != nla_attr_size(sizeof(*ctl)))
+ return -EINVAL;
+
sch->limit = ctl->limit;
return 0;
}