hwmon: (dell-smm-hwmon) Fix fan mutliplier detection for 3rd fan
authorArmin Wolf <W_Armin@gmx.de>
Wed, 28 Jul 2021 22:15:57 +0000 (00:15 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 17 Aug 2021 21:54:26 +0000 (14:54 -0700)
There are up to three fans, but the detection omits the 3rd one.
Fix that by using DELL_SMM_NO_FANS.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Fixes: 747bc8b063ae (hwmon: (dell-smm) Detect fan with index=2)
Link: https://lore.kernel.org/r/20210728221557.8891-7-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/dell-smm-hwmon.c

index aaf864dbe53a51af336264e74a18ce838d293735..206418405440c3fea29efcbc51f18707bd1a7e54 100644 (file)
@@ -1263,7 +1263,7 @@ static int __init dell_smm_probe(struct platform_device *pdev)
                 * Autodetect fan multiplier based on nominal rpm
                 * If fan reports rpm value too high then set multiplier to 1
                 */
-               for (fan = 0; fan < 2; ++fan) {
+               for (fan = 0; fan < DELL_SMM_NO_FANS; ++fan) {
                        ret = i8k_get_fan_nominal_speed(data, fan, data->i8k_fan_max);
                        if (ret < 0)
                                continue;