ibmvnic: check failover_pending in login response
authorSukadev Bhattiprolu <sukadev@linux.ibm.com>
Wed, 8 Sep 2021 16:58:20 +0000 (09:58 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 9 Sep 2021 09:54:55 +0000 (10:54 +0100)
If a failover occurs before a login response is received, the login
response buffer maybe undefined. Check that there was no failover
before accessing the login response buffer.

Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol")
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index 6aa6ff89a76511ff840e545e3bd0dc9ec5c4faff..a4579b3401204fe0698baf65a79842922112b4ee 100644 (file)
@@ -4708,6 +4708,14 @@ static int handle_login_rsp(union ibmvnic_crq *login_rsp_crq,
                return 0;
        }
 
+       if (adapter->failover_pending) {
+               adapter->init_done_rc = -EAGAIN;
+               netdev_dbg(netdev, "Failover pending, ignoring login response\n");
+               complete(&adapter->init_done);
+               /* login response buffer will be released on reset */
+               return 0;
+       }
+
        netdev->mtu = adapter->req_mtu - ETH_HLEN;
 
        netdev_dbg(adapter->netdev, "Login Response Buffer:\n");