docs: do not generate redirects on error
authorErik Faye-Lund <erik.faye-lund@collabora.com>
Thu, 22 Apr 2021 11:46:41 +0000 (13:46 +0200)
committerMarge Bot <eric+marge@anholt.net>
Wed, 5 May 2021 09:37:18 +0000 (09:37 +0000)
The build-finished event is also triggered when there's an error. I
somehow got the second argument wrong, and ended up ignoring the case.
This can lead to new exceptions being thrown due to missing files, that
ends up hiding the real problem.

Fixes: 64a4ba9e1ce ("docs: add an extension to generate redirects")
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10407>

docs/_exts/redirects.py

index 90d69ef..1adf3cd 100644 (file)
@@ -6,8 +6,8 @@ def create_redirect(dst):
     tpl = '<html><head><meta http-equiv="refresh" content="0; url={0}"><script>window.location.replace("{0}")</script></head></html>'
     return tpl.format(dst)
 
-def create_redirects(app, docname):
-    if not app.builder.name == 'html':
+def create_redirects(app, exception):
+    if exception is not None or not app.builder.name == 'html':
         return
     for src, dst in app.config.html_redirects:
         path = os.path.join(app.outdir, '{0}.html'.format(src))