gpio: zynq: Fix warnings in the driver
authorNava kishore Manne <nava.manne@xilinx.com>
Mon, 7 Aug 2017 11:02:00 +0000 (13:02 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 14 Aug 2017 14:00:08 +0000 (16:00 +0200)
This patch fixes the below warning
-->Block comments should align the * on each line.
-->suspect code indent for conditional statements.
-->Prefer 'unsigned int' to bare use of 'unsigned'

Signed-off-by: Nava kishore Manne <navam@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-zynq.c

index 0129f82..3120d0c 100644 (file)
@@ -195,10 +195,10 @@ static inline void zynq_gpio_get_bank_pin(unsigned int pin_num,
        for (bank = 0; bank < gpio->p_data->max_bank; bank++) {
                if ((pin_num >= gpio->p_data->bank_min[bank]) &&
                        (pin_num <= gpio->p_data->bank_max[bank])) {
-                               *bank_num = bank;
-                               *bank_pin_num = pin_num -
-                                               gpio->p_data->bank_min[bank];
-                               return;
+                       *bank_num = bank;
+                       *bank_pin_num = pin_num -
+                                       gpio->p_data->bank_min[bank];
+                       return;
                }
        }
 
@@ -712,7 +712,7 @@ static int __maybe_unused zynq_gpio_runtime_resume(struct device *dev)
        return clk_prepare_enable(gpio->clk);
 }
 
-static int zynq_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int zynq_gpio_request(struct gpio_chip *chip, unsigned int offset)
 {
        int ret;
 
@@ -725,7 +725,7 @@ static int zynq_gpio_request(struct gpio_chip *chip, unsigned offset)
        return ret < 0 ? ret : 0;
 }
 
-static void zynq_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void zynq_gpio_free(struct gpio_chip *chip, unsigned int offset)
 {
        pm_runtime_put(chip->parent);
 }