tdm_sprd_display: clean up sprd_output_get_capability() 37/102237/1
authorYoungJun Cho <yj44.cho@samsung.com>
Mon, 5 Dec 2016 08:17:19 +0000 (17:17 +0900)
committerYoungJun Cho <yj44.cho@samsung.com>
Mon, 5 Dec 2016 08:20:28 +0000 (17:20 +0900)
This patch cleans up sprd_output_get_capability().
The 'failed_get' label routine is not proper to this.

Change-Id: I7b56d68161127aef21e5de6f2276f2b7132f0e41
Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
src/tdm_sprd_display.c

index 79388d2..dc05869 100644 (file)
@@ -947,7 +947,8 @@ sprd_output_get_capability(tdm_output *output, tdm_caps_output *caps)
        if (!caps->modes) {
                ret = TDM_ERROR_OUT_OF_MEMORY;
                TDM_ERR("alloc failed\n");
-               goto failed_get;
+               memset(caps, 0, sizeof(tdm_caps_output));
+               return ret;
        }
        for (i = 0; i < caps->mode_count; i++)
                caps->modes[i] = output_data->output_modes[i];
@@ -966,13 +967,6 @@ sprd_output_get_capability(tdm_output *output, tdm_caps_output *caps)
        caps->props = NULL;
 
        return TDM_ERROR_NONE;
-failed_get:
-       if (caps->modes)
-               free(caps->modes);
-       if (caps->props)
-               free(caps->props);
-       memset(caps, 0, sizeof(tdm_caps_output));
-       return ret;
 }
 
 tdm_layer **