i2c: mpc: Remove redundant NULL check
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Tue, 13 Apr 2021 05:09:54 +0000 (17:09 +1200)
committerWolfram Sang <wsa@kernel.org>
Tue, 13 Apr 2021 12:23:40 +0000 (14:23 +0200)
In mpc_i2c_get_fdr_8xxx div is assigned as we iterate through the
mpc_i2c_dividers_8xxx array. By the time we exit the loop div will
either have the value that matches the requested speed or be pointing at
the last entry in mpc_i2c_dividers_8xxx. Checking for div being NULL
after the loop is redundant so remove the check.

Reported-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-mpc.c

index 6e5614a..3c8bcdf 100644 (file)
@@ -399,7 +399,7 @@ static int mpc_i2c_get_fdr_8xxx(struct device_node *node, u32 clock,
        }
 
        *real_clk = fsl_get_sys_freq() / prescaler / div->divider;
-       return div ? (int)div->fdr : -EINVAL;
+       return (int)div->fdr;
 }
 
 static void mpc_i2c_setup_8xxx(struct device_node *node,