Cast the argument to g_object_add/remove_weak_pointer to the wrong type,

	* libsoup/soup-connection.c (set_current_request,
	clear_current_request): Cast the argument to
	g_object_add/remove_weak_pointer to the wrong type, to make gcc
	4.1 happy, because C is stupid and "void **" means "a pointer to a
	void *", not "a pointer to any kind of pointer".

	* libsoup/soup-xmlrpc-response.c
	(soup_xmlrpc_value_dump_internal): fix gccism. #320349, from
	Roland Illig.

diff --git a/ChangeLog b/ChangeLog
index d232c7c..dbe8579 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2005-11-01  Dan Winship  <danw@novell.com>
+
+       * libsoup/soup-connection.c (set_current_request,
+       clear_current_request): Cast the argument to
+       g_object_add/remove_weak_pointer to the wrong type, to make gcc
+       4.1 happy, because C is stupid and "void **" means "a pointer to a
+       void *", not "a pointer to any kind of pointer".
+
+       * libsoup/soup-xmlrpc-response.c
+       (soup_xmlrpc_value_dump_internal): fix gccism. #320349, from
+       Roland Illig.
+
 2005-10-27  Dan Winship  <danw@novell.com>
 
        * libsoup/soup-socket.c (soup_socket_client_new_async,

diff --git a/libsoup/soup-connection.c b/libsoup/soup-connection.c
index 1f85e37..5302768 100644 (file)
--- a/libsoup/soup-connection.c
+++ b/libsoup/soup-connection.c
@@ -346,7 +346,7 @@ set_current_request (SoupConnectionPrivate *priv, SoupMessage *req)
        req->status = SOUP_MESSAGE_STATUS_RUNNING;
        priv->cur_req = req;
        priv->in_use = TRUE;
-       g_object_add_weak_pointer (G_OBJECT (req), (gpointer *)&priv->cur_req);
+       g_object_add_weak_pointer (G_OBJECT (req), (gpointer)&priv->cur_req);
 }
 
 static void
@@ -358,7 +358,7 @@ clear_current_request (SoupConnection *conn)
                SoupMessage *cur_req = priv->cur_req;
 
                g_object_remove_weak_pointer (G_OBJECT (priv->cur_req),
-                                             (gpointer *)&priv->cur_req);
+                                             (gpointer)&priv->cur_req);
                priv->cur_req = NULL;
 
                if (!soup_message_is_keepalive (cur_req))

diff --git a/libsoup/soup-xmlrpc-response.c b/libsoup/soup-xmlrpc-response.c
index 16f8572..a0b8beb 100644 (file)
--- a/libsoup/soup-xmlrpc-response.c
+++ b/libsoup/soup-xmlrpc-response.c
@@ -612,9 +612,9 @@ soup_xmlrpc_value_dump_internal (SoupXmlrpcValue *value, int d)
                        if (!soup_xmlrpc_value_array_get_iterator (value, &iter))
                                g_printerr ("BAD ARRAY\n");
                        else {
-                               g_printerr ("ARRAY\n");
                                SoupXmlrpcValue *evalue;
                                int i = 0;
+                               g_printerr ("ARRAY\n");
                                while (iter != NULL) {
                                        soup_xmlrpc_value_array_iterator_get_value (iter, &evalue);
                                        soup_xmlrpc_value_dump_array_element (i, evalue, GINT_TO_POINTER (d+1));