serial: uniphier: flush transmitter before changing hardware settings
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 9 Jul 2020 16:12:07 +0000 (01:12 +0900)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Sat, 11 Jul 2020 12:30:21 +0000 (21:30 +0900)
Ensure the transmitter is empty when chaining the baudrate or any
hardware settings. If a character is remaining in the transmitter,
the console will be garbled.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
drivers/serial/serial_uniphier.c

index 2ffab00..aaf8657 100644 (file)
@@ -43,6 +43,10 @@ static int uniphier_serial_setbrg(struct udevice *dev, int baudrate)
 
        divisor = DIV_ROUND_CLOSEST(priv->uartclk, mode_x_div * baudrate);
 
+       /* flush the trasmitter before changing hw setting */
+       while (!(readl(priv->membase + UNIPHIER_UART_LSR) & UART_LSR_TEMT))
+               ;
+
        writel(divisor, priv->membase + UNIPHIER_UART_DLR);
 
        return 0;
@@ -132,6 +136,10 @@ static int uniphier_serial_probe(struct udevice *dev)
 
        priv->uartclk = clk_data->clk_rate;
 
+       /* flush the trasmitter empty before changing hw setting */
+       while (!(readl(priv->membase + UNIPHIER_UART_LSR) & UART_LSR_TEMT))
+               ;
+
        tmp = readl(priv->membase + UNIPHIER_UART_LCR_MCR);
        tmp &= ~UNIPHIER_UART_LCR_MASK;
        tmp |= FIELD_PREP(UNIPHIER_UART_LCR_MASK, UART_LCR_WLEN8);