ASoC: arizona: Exit startup early if no runtime
authorCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Tue, 29 Dec 2015 09:49:19 +0000 (09:49 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 30 Dec 2015 17:26:08 +0000 (17:26 +0000)
commit 9b8ef9f6b3fc ("ASoC: dapm: Add startup & shutdown for dai_links")

Added support for calling startup on CODEC to CODEC links, however this
is called with a NULL runtime pointer. There isn't really a sensible way
to pass a valid runtime pointer to a CODEC to CODEC link at the moment,
so we need to make the startup function safe for NULL runtimes.

This patch returns from the Arizona startup function early if there is no
runtime, this is perfectly safe as all the startup function does is set
the PCM constraints for user-space which arn't relevant to a CODEC to
CODEC link anyway.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/arizona.c

index 38a73e3..88e2c74 100644 (file)
@@ -1494,6 +1494,9 @@ static int arizona_startup(struct snd_pcm_substream *substream,
        const struct snd_pcm_hw_constraint_list *constraint;
        unsigned int base_rate;
 
+       if (!substream->runtime)
+               return 0;
+
        switch (dai_priv->clk) {
        case ARIZONA_CLK_SYSCLK:
                base_rate = priv->sysclk;