crypto: arm/aes-neonbs - Use PTR_ERR_OR_ZERO()
authorGomonovych, Vasyl <gomonovych@gmail.com>
Mon, 27 Nov 2017 23:06:06 +0000 (00:06 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 11 Dec 2017 11:36:56 +0000 (22:36 +1100)
Fix ptr_ret.cocci warnings:
arch/arm/crypto/aes-neonbs-glue.c:184:1-3: WARNING: PTR_ERR_OR_ZERO can be used
arch/arm/crypto/aes-neonbs-glue.c:261:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm/crypto/aes-neonbs-glue.c

index 18768f3..07e3194 100644 (file)
@@ -181,9 +181,8 @@ static int cbc_init(struct crypto_tfm *tfm)
        struct aesbs_cbc_ctx *ctx = crypto_tfm_ctx(tfm);
 
        ctx->enc_tfm = crypto_alloc_cipher("aes", 0, 0);
-       if (IS_ERR(ctx->enc_tfm))
-               return PTR_ERR(ctx->enc_tfm);
-       return 0;
+
+       return PTR_ERR_OR_ZERO(ctx->enc_tfm);
 }
 
 static void cbc_exit(struct crypto_tfm *tfm)
@@ -258,9 +257,8 @@ static int xts_init(struct crypto_tfm *tfm)
        struct aesbs_xts_ctx *ctx = crypto_tfm_ctx(tfm);
 
        ctx->tweak_tfm = crypto_alloc_cipher("aes", 0, 0);
-       if (IS_ERR(ctx->tweak_tfm))
-               return PTR_ERR(ctx->tweak_tfm);
-       return 0;
+
+       return PTR_ERR_OR_ZERO(ctx->tweak_tfm);
 }
 
 static void xts_exit(struct crypto_tfm *tfm)