Fix a crash with assembler source and -g.

llvm-mc or clang with -g normally produces debug info describing the
assembler source itself; however, if that source already contains some
.file/.loc directives, we should instead emit the debug info described
by those directives.  For certain assembler sources seen in the wild
(particularly in the Chrome build) this was causing a crash due to
incorrect assumptions about legal sequences of assembler source text.

Fixes PR38994.

Differential Revision: https://reviews.llvm.org/D63573

llvm-svn: 364039

diff --git a/llvm/include/llvm/MC/MCDwarf.h b/llvm/include/llvm/MC/MCDwarf.h
index 2a24347075a7d1bcf07737a75f3f533321630d96..1a37aafd065422041537dee25dce4a03c750a884 100644 (file)
--- a/llvm/include/llvm/MC/MCDwarf.h
+++ b/llvm/include/llvm/MC/MCDwarf.h
@@ -261,6 +261,14 @@ public:
     HasSource = Source.hasValue();
   }
 
+  void resetFileTable() {
+    MCDwarfDirs.clear();
+    MCDwarfFiles.clear();
+    RootFile.Name.clear();
+    resetMD5Usage();
+    HasSource = false;
+  }
+
 private:
   void emitV2FileDirTables(MCStreamer *MCOS) const;
   void emitV5FileDirTables(MCStreamer *MCOS, Optional<MCDwarfLineStr> &LineStr) const;
@@ -326,12 +334,7 @@ public:
     Header.HasSource = Source.hasValue();
   }
 
-  void resetRootFile() {
-    assert(Header.MCDwarfFiles.empty());
-    Header.RootFile.Name.clear();
-    Header.resetMD5Usage();
-    Header.HasSource = false;
-  }
+  void resetFileTable() { Header.resetFileTable(); }
 
   bool hasRootFile() const { return !Header.RootFile.Name.empty(); }
 

diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp
index f0d78a43190f3aee73cb9382c0524440b260c97e..694845e74f5f882e1ff5747b4bcebe05a9e10207 100644 (file)
--- a/llvm/lib/MC/MCParser/AsmParser.cpp
+++ b/llvm/lib/MC/MCParser/AsmParser.cpp
@@ -3395,9 +3395,9 @@ bool AsmParser::parseDirectiveFile(SMLoc DirectiveLoc) {
   } else {
     // In case there is a -g option as well as debug info from directive .file,
     // we turn off the -g option, directly use the existing debug info instead.
-    // Also reset any implicit ".file 0" for the assembler source.
+    // Throw away any implicit file table for the assembler source.
     if (Ctx.getGenDwarfForAssembly()) {
-      Ctx.getMCDwarfLineTable(0).resetRootFile();
+      Ctx.getMCDwarfLineTable(0).resetFileTable();
       Ctx.setGenDwarfForAssembly(false);
     }
 

diff --git a/llvm/test/MC/AsmParser/directive_file-g.s b/llvm/test/MC/AsmParser/directive_file-g.s
new file mode 100644 (file)
index 0000000..3b769f1
--- /dev/null
+++ b/llvm/test/MC/AsmParser/directive_file-g.s
@@ -0,0 +1,24 @@
+## Make sure that using -g (or equivalent) on an asm file that already has\r
+## debug-info directives in it will correctly ignore the -g and produce\r
+## debug info corresponding to the directives in the source.\r
+## Note gcc accepts ".file 1" after a label, although not after an opcode.\r
+## If no other directives appear, gcc emits no debug info at all.\r
+\r
+# RUN: llvm-mc -g -triple i386-unknown-unknown -filetype=obj %s -o %t\r
+# RUN: llvm-dwarfdump -debug-info -debug-line %t | FileCheck %s\r
+\r
+foo:\r
+        .file 1 "a.c"\r
+        .loc 1 1 1\r
+        nop\r
+\r
+# CHECK: .debug_info\r
+## gcc does generate a DW_TAG_compile_unit in this case, with or without\r
+## -g on the command line, but we do not.\r
+# CHECK-EMPTY:\r
+# CHECK_NEXT: .debug_line\r
+# CHECK: file_names[ 1]:\r
+# CHECK-NEXT: name: "a.c"\r
+# CHECK-NEXT: dir_index: 0\r
+# CHECK: 0x{{0+}}0 1 1 1 0 0 is_stmt\r
+# CHECK: 0x{{0+}}1 1 1 1 0 0 is_stmt end_sequence\r