dlm: fix error return code in sctp_accept_from_sock()
authorWei Yongjun <weiyongjun1@huawei.com>
Sat, 22 Oct 2016 14:37:36 +0000 (14:37 +0000)
committerDavid Teigland <teigland@redhat.com>
Mon, 24 Oct 2016 15:01:51 +0000 (10:01 -0500)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lowcomms.c

index df680a2..7d398d3 100644 (file)
@@ -879,7 +879,8 @@ static int sctp_accept_from_sock(struct connection *con)
        }
 
        make_sockaddr(&prim.ssp_addr, 0, &addr_len);
-       if (addr_to_nodeid(&prim.ssp_addr, &nodeid)) {
+       ret = addr_to_nodeid(&prim.ssp_addr, &nodeid);
+       if (ret) {
                unsigned char *b = (unsigned char *)&prim.ssp_addr;
 
                log_print("reject connect from unknown addr");