coresight: cti-sysfs: Mark coresight_cti_reg_store() as __maybe_unused
authorNathan Chancellor <nathan@kernel.org>
Thu, 1 Sep 2022 19:50:55 +0000 (12:50 -0700)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Tue, 6 Sep 2022 20:14:33 +0000 (14:14 -0600)
When building without CONFIG_CORESIGHT_CTI_INTEGRATION_REGS, there is a
warning about coresight_cti_reg_store() being unused in the file:

  drivers/hwtracing/coresight/coresight-cti-sysfs.c:184:16: warning: 'coresight_cti_reg_store' defined but not used [-Wunused-function]
    184 | static ssize_t coresight_cti_reg_store(struct device *dev,
        |                ^~~~~~~~~~~~~~~~~~~~~~~

This is expected as coresight_cti_reg_store() is only used in the
coresight_cti_reg_rw macro, which is only used in a block guarded by
CONFIG_CORESIGHT_CTI_INTEGRATION_REGS. Mark coresight_cti_reg_store() as
__maybe_unused to clearly indicate that the function may be unused
depending on the configuration.

Fixes: fbca79e55429 ("coresight: cti-sysfs: Re-use same functions for similar sysfs register accessors")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: James Clark <james.clark@arm.com>
Link: https://lore.kernel.org/r/20220901195055.1932340-1-nathan@kernel.org
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/hwtracing/coresight/coresight-cti-sysfs.c

index 478b8d3..6d59c81 100644 (file)
@@ -181,9 +181,9 @@ static ssize_t coresight_cti_reg_show(struct device *dev,
 }
 
 /* Write registers with power check only (no enable check). */
-static ssize_t coresight_cti_reg_store(struct device *dev,
-                                      struct device_attribute *attr,
-                                      const char *buf, size_t size)
+static __maybe_unused ssize_t coresight_cti_reg_store(struct device *dev,
+                                                     struct device_attribute *attr,
+                                                     const char *buf, size_t size)
 {
        struct cti_drvdata *drvdata = dev_get_drvdata(dev->parent);
        struct cs_off_attribute *cti_attr = container_of(attr, struct cs_off_attribute, attr);