projects
/
platform
/
kernel
/
kernel-mfld-blackbay.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b02c387
)
[WATCHDOG] gef_wdt.c: fsl_get_sys_freq() failure not noticed
author
Roel Kluin
<roel.kluin@gmail.com>
Tue, 3 Mar 2009 14:10:05 +0000
(15:10 +0100)
committer
Wim Van Sebroeck
<wim@iguana.be>
Thu, 5 Mar 2009 14:02:53 +0000
(14:02 +0000)
fsl_get_sys_freq() may return -1 when 'soc' isn't found, but in
gef_wdt_probe() 'freq' is unsigned, so the test doesn't catch that.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/watchdog/gef_wdt.c
patch
|
blob
|
history
diff --git
a/drivers/watchdog/gef_wdt.c
b/drivers/watchdog/gef_wdt.c
index
f0c2b7a
..
734d980
100644
(file)
--- a/
drivers/watchdog/gef_wdt.c
+++ b/
drivers/watchdog/gef_wdt.c
@@
-269,7
+269,7
@@
static int __devinit gef_wdt_probe(struct of_device *dev,
bus_clk = 133; /* in MHz */
freq = fsl_get_sys_freq();
- if (freq
> 0
)
+ if (freq
!= -1
)
bus_clk = freq;
/* Map devices registers into memory */