mei: drop ready bits check after start
authorAlexander Usyskin <alexander.usyskin@intel.com>
Wed, 7 Sep 2022 21:51:10 +0000 (00:51 +0300)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Mon, 12 Sep 2022 12:23:11 +0000 (15:23 +0300)
The check that hardware and host ready bits are set after start
is redundant and may fail and disable driver if there is
back-to-back link reset issued right after start.
This happens during pxp mode transitions when firmware
undergo reset. Remove these checks to eliminate such failures.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220907215113.1596567-14-tomas.winkler@intel.com
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/misc/mei/init.c

index 1b4d5d7..bac8852 100644 (file)
@@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev)
                goto err;
        }
 
-       if (!mei_host_is_ready(dev)) {
-               dev_err(dev->dev, "host is not ready.\n");
-               goto err;
-       }
-
-       if (!mei_hw_is_ready(dev)) {
-               dev_err(dev->dev, "ME is not ready.\n");
-               goto err;
-       }
-
        if (!mei_hbm_version_is_supported(dev)) {
                dev_dbg(dev->dev, "MEI start failed.\n");
                goto err;