ARM: dts: axp803/axp81x: Drop GPIO LDO pinctrl nodes
authorSamuel Holland <samuel@sholland.org>
Fri, 16 Sep 2022 04:27:50 +0000 (23:27 -0500)
committerJernej Skrabec <jernej.skrabec@gmail.com>
Wed, 26 Oct 2022 20:15:04 +0000 (22:15 +0200)
The "ldo-io0" and "ldo-io1" regulators are enabled/disabled by toggling
the pinmux between two functions. This happens in the regulator driver.
Setting the pinmux to "ldo" in the DT is inappropriate because it would
enable the regulator before the driver has a chance to set the correct
initial voltage.

Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20220916042751.47906-2-samuel@sholland.org
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
arch/arm/boot/dts/axp81x.dtsi
arch/arm64/boot/dts/allwinner/axp803.dtsi

index b93387b..ebaf1c3 100644 (file)
                compatible = "x-powers,axp813-gpio";
                gpio-controller;
                #gpio-cells = <2>;
-
-               gpio0_ldo: gpio0-ldo-pin {
-                       pins = "GPIO0";
-                       function = "ldo";
-               };
-
-               gpio1_ldo: gpio1-ldo-pin {
-                       pins = "GPIO1";
-                       function = "ldo";
-               };
        };
 
        battery_power_supply: battery-power {
                };
 
                reg_ldo_io0: ldo-io0 {
-                       pinctrl-names = "default";
-                       pinctrl-0 = <&gpio0_ldo>;
                        /* Disable by default to avoid conflicts with GPIO */
                        status = "disabled";
                };
 
                reg_ldo_io1: ldo-io1 {
-                       pinctrl-names = "default";
-                       pinctrl-0 = <&gpio1_ldo>;
                        /* Disable by default to avoid conflicts with GPIO */
                        status = "disabled";
                };
index 578ef36..a6b4b87 100644 (file)
                compatible = "x-powers,axp803-gpio", "x-powers,axp813-gpio";
                gpio-controller;
                #gpio-cells = <2>;
-
-               gpio0_ldo: gpio0-ldo-pin {
-                       pins = "GPIO0";
-                       function = "ldo";
-               };
-
-               gpio1_ldo: gpio1-ldo-pin {
-                       pins = "GPIO1";
-                       function = "ldo";
-               };
        };
 
        battery_power_supply: battery-power {