gerror: Don't leak when warning about overwriting an error

While not strictly necessary, this fixes a false positive
leak in the tests.

https://bugzilla.gnome.org/show_bug.cgi?id=627423

diff --git a/glib/gerror.c b/glib/gerror.c
index 2adbdf84d38ec794f0a2822cc8bdf27870a4646a..809d0c940af1cf86723fd2c655d8253503a5c0db 100644 (file)
--- a/glib/gerror.c
+++ b/glib/gerror.c
@@ -587,16 +587,13 @@ g_set_error_literal (GError      **err,
                      gint          code,
                      const gchar  *message)
 {
-  GError *new;
-
   if (err == NULL)
     return;
 
-  new = g_error_new_literal (domain, code, message);
   if (*err == NULL)
-    *err = new;
+    *err = g_error_new_literal (domain, code, message);
   else
-    g_warning (ERROR_OVERWRITTEN_WARNING, new->message); 
+    g_warning (ERROR_OVERWRITTEN_WARNING, message);
 }
 
 /**