arm64: dts: qcom: sc7180: Set 'polling-delay-passive' for thermal zones back to 250 ms
authorMatthias Kaehlcke <mka@chromium.org>
Wed, 11 Nov 2020 20:03:43 +0000 (12:03 -0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 23 Nov 2020 05:04:34 +0000 (23:04 -0600)
Commit 22337b91022d ("arm64: dts: qcom: sc7180: Changed polling mode
in Thermal-zones node") sets both 'polling-delay' and
'polling-delay-passive' to zero with the rationale that TSENS interrupts
are enabled. A TSENS interrupt fires when the temperature of a thermal
zone reaches a trip point, which makes regular polling below the passive
trip point temperature unnecessary. However the situation is different
when passive cooling is active, regular polling is still needed to
trigger a periodic evaluation of the thermal zone by the thermal governor.

Change 'polling-delay-passive' back to the original value of 250 ms.
Commit 2315ae70af95 ("arm64: dts: qcom: sc7180: Add gpu cooling
support") recently changed the value for the GPU thermal zones from
zero to 100 ms, also set it to 250 ms for uniformity. If some zones
really need different values these can be changed in dedicated patches.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Fixes: 22337b91022d ("arm64: dts: qcom: sc7180: Changed polling mode in Thermal-zones node")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Link: https://lore.kernel.org/r/20201111120334.1.Ifc04ea235c3c370e3b21ec3b4d5dead83cc403b4@changeid
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
arch/arm64/boot/dts/qcom/sc7180.dtsi

index 625e922..c0efb10 100644 (file)
 
        thermal-zones {
                cpu0-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 1>;
                };
 
                cpu1-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 2>;
                };
 
                cpu2-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 3>;
                };
 
                cpu3-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 4>;
                };
 
                cpu4-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 5>;
                };
 
                cpu5-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 6>;
                };
 
                cpu6-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 9>;
                };
 
                cpu7-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 10>;
                };
 
                cpu8-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 11>;
                };
 
                cpu9-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 12>;
                };
 
                aoss0-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 0>;
                };
 
                cpuss0-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 7>;
                };
 
                cpuss1-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 8>;
                };
 
                gpuss0-thermal {
-                       polling-delay-passive = <100>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 13>;
                };
 
                gpuss1-thermal {
-                       polling-delay-passive = <100>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens0 14>;
                };
 
                aoss1-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 0>;
                };
 
                cwlan-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 1>;
                };
 
                audio-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 2>;
                };
 
                ddr-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 3>;
                };
 
                q6-hvx-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 4>;
                };
 
                camera-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 5>;
                };
 
                mdm-core-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 6>;
                };
 
                mdm-dsp-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 7>;
                };
 
                npu-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 8>;
                };
 
                video-thermal {
-                       polling-delay-passive = <0>;
+                       polling-delay-passive = <250>;
                        polling-delay = <0>;
 
                        thermal-sensors = <&tsens1 9>;