staging: usbip: reformat function pickup_urb_and_free_priv

re-indent funtion "pickup_urb_and_free_priv" to improve readability.

Signed-off-by: Stefan Reif <ke42caxa@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/usbip/vhci_rx.c b/drivers/staging/usbip/vhci_rx.c
index faf8e60..50d6fd5 100644 (file)
--- a/drivers/staging/usbip/vhci_rx.c
+++ b/drivers/staging/usbip/vhci_rx.c
@@ -31,33 +31,37 @@ struct urb *pickup_urb_and_free_priv(struct vhci_device *vdev, __u32 seqnum)
        int status;
 
        list_for_each_entry_safe(priv, tmp, &vdev->priv_rx, list) {
-               if (priv->seqnum == seqnum) {
-                       urb = priv->urb;
-                       status = urb->status;
-
-                       usbip_dbg_vhci_rx("find urb %p vurb %p seqnum %u\n",
-                                         urb, priv, seqnum);
-
-                       /* TODO: fix logic here to improve indent situtation */
-                       if (status != -EINPROGRESS) {
-                               if (status == -ENOENT ||
-                                   status == -ECONNRESET)
-                                       dev_info(&urb->dev->dev,
-                                                "urb %p was unlinked "
-                                                "%ssynchronuously.\n", urb,
-                                                status == -ENOENT ? "" : "a");
-                               else
-                                       dev_info(&urb->dev->dev,
-                                                "urb %p may be in a error, "
-                                                "status %d\n", urb, status);
-                       }
-
-                       list_del(&priv->list);
-                       kfree(priv);
-                       urb->hcpriv = NULL;
-
+               if (priv->seqnum != seqnum)
+                       continue;
+
+               urb = priv->urb;
+               status = urb->status;
+
+               usbip_dbg_vhci_rx("find urb %p vurb %p seqnum %u\n",
+                               urb, priv, seqnum);
+
+               switch (status) {
+               case -ENOENT:
+                       /* fall through */
+               case -ECONNRESET:
+                       dev_info(&urb->dev->dev,
+                                "urb %p was unlinked %ssynchronuously.\n", urb,
+                                status == -ENOENT ? "" : "a");
+                       break;
+               case -EINPROGRESS:
+                       /* no info output */
                        break;
+               default:
+                       dev_info(&urb->dev->dev,
+                                "urb %p may be in a error, status %d\n", urb,
+                                status);
                }
+
+               list_del(&priv->list);
+               kfree(priv);
+               urb->hcpriv = NULL;
+
+               break;
        }
 
        return urb;