usb: dwc3: pci: Fix reference count leak in dwc3_pci_resume_work
authorAditya Pakki <pakki001@umn.edu>
Sun, 14 Jun 2020 03:15:25 +0000 (22:15 -0500)
committerFelipe Balbi <balbi@kernel.org>
Wed, 24 Jun 2020 06:42:39 +0000 (09:42 +0300)
dwc3_pci_resume_work() calls pm_runtime_get_sync() that increments
the reference counter. In case of failure, decrement the reference
before returning.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/dwc3/dwc3-pci.c

index b673727..96c05b1 100644 (file)
@@ -206,8 +206,10 @@ static void dwc3_pci_resume_work(struct work_struct *work)
        int ret;
 
        ret = pm_runtime_get_sync(&dwc3->dev);
-       if (ret)
+       if (ret) {
+               pm_runtime_put_sync_autosuspend(&dwc3->dev);
                return;
+       }
 
        pm_runtime_mark_last_busy(&dwc3->dev);
        pm_runtime_put_sync_autosuspend(&dwc3->dev);