hid: fix return type of input_configured callback 61/158361/1
authorSeung-Woo Kim <sw0312.kim@samsung.com>
Tue, 31 Oct 2017 06:37:32 +0000 (15:37 +0900)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Tue, 31 Oct 2017 08:05:48 +0000 (17:05 +0900)
The return type of input_configured callback is fixed from void to
int from header. Fix return type of input_configured callback from
hid drivers to fix build warnings.

This is partially picked from the commit 9154301a47b3
("HID: hid-input: allow input_configured callback return errors")
in mainline.

Change-Id: Id529359eb7d6d005aac28596f0ec65dde59b5564
Fixes: 5925993fe56e ("HID: Add input_register callback.") in https://android.googlesource.com/kernel/common
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
drivers/hid/hid-appleir.c
drivers/hid/hid-ntrig.c

index a42e6a3..af78bf2 100644 (file)
@@ -256,7 +256,7 @@ out:
        return 0;
 }
 
-static void appleir_input_configured(struct hid_device *hid,
+static int appleir_input_configured(struct hid_device *hid,
                struct hid_input *hidinput)
 {
        struct input_dev *input_dev = hidinput->input;
@@ -275,6 +275,8 @@ static void appleir_input_configured(struct hid_device *hid,
        for (i = 0; i < ARRAY_SIZE(appleir_key_table); i++)
                set_bit(appleir->keymap[i], input_dev->keybit);
        clear_bit(KEY_RESERVED, input_dev->keybit);
+
+       return 0;
 }
 
 static int appleir_input_mapping(struct hid_device *hid,
index 5482156..46361fd 100644 (file)
@@ -859,14 +859,14 @@ not_claimed_input:
        return 1;
 }
 
-static void ntrig_input_configured(struct hid_device *hid,
+static int ntrig_input_configured(struct hid_device *hid,
                struct hid_input *hidinput)
 
 {
        struct input_dev *input = hidinput->input;
 
        if (hidinput->report->maxfield < 1)
-               return;
+               return 0;
 
        switch (hidinput->report->field[0]->application) {
        case HID_DG_PEN:
@@ -890,6 +890,8 @@ static void ntrig_input_configured(struct hid_device *hid,
                                                        "N-Trig MultiTouch";
                break;
        }
+
+       return 0;
 }
 
 static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)