pxa3xx-gcu: stop embedding file_operations into device-private object
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 6 Apr 2013 00:44:08 +0000 (20:44 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 9 Apr 2013 18:16:40 +0000 (14:16 -0400)
no need to do that anymore...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/video/pxa3xx-gcu.c

index 4c318a3..97563c5 100644 (file)
@@ -101,7 +101,6 @@ struct pxa3xx_gcu_priv {
        dma_addr_t                shared_phys;
        struct resource          *resource_mem;
        struct miscdevice         misc_dev;
-       struct file_operations    misc_fops;
        wait_queue_head_t         wait_idle;
        wait_queue_head_t         wait_free;
        spinlock_t                spinlock;
@@ -577,6 +576,13 @@ free_buffers(struct platform_device *dev,
        priv->free = NULL;
 }
 
+static const struct file_operations misc_fops = {
+       .owner  = THIS_MODULE,
+       .write  = pxa3xx_gcu_misc_write,
+       .unlocked_ioctl = pxa3xx_gcu_misc_ioctl,
+       .mmap   = pxa3xx_gcu_misc_mmap
+};
+
 static int pxa3xx_gcu_probe(struct platform_device *dev)
 {
        int i, ret, irq;
@@ -604,14 +610,9 @@ static int pxa3xx_gcu_probe(struct platform_device *dev)
         * container_of(). This isn't really necessary as we have a fixed minor
         * number anyway, but this is to avoid statics. */
 
-       priv->misc_fops.owner   = THIS_MODULE;
-       priv->misc_fops.write   = pxa3xx_gcu_misc_write;
-       priv->misc_fops.unlocked_ioctl = pxa3xx_gcu_misc_ioctl;
-       priv->misc_fops.mmap    = pxa3xx_gcu_misc_mmap;
-
        priv->misc_dev.minor    = MISCDEV_MINOR,
        priv->misc_dev.name     = DRV_NAME,
-       priv->misc_dev.fops     = &priv->misc_fops,
+       priv->misc_dev.fops     = &misc_fops,
 
        /* register misc device */
        ret = misc_register(&priv->misc_dev);