kvm: exit halt polling on need_resched() as well
authorBenjamin Segall <bsegall@google.com>
Thu, 29 Apr 2021 16:22:34 +0000 (16:22 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 3 May 2021 15:25:36 +0000 (11:25 -0400)
single_task_running() is usually more general than need_resched()
but CFS_BANDWIDTH throttling will use resched_task() when there
is just one task to get the task to block. This was causing
long-need_resched warnings and was likely allowing VMs to
overrun their quota when halt polling.

Signed-off-by: Ben Segall <bsegall@google.com>
Signed-off-by: Venkatesh Srinivas <venkateshs@chromium.org>
Message-Id: <20210429162233.116849-1-venkateshs@chromium.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: stable@vger.kernel.org
Reviewed-by: Jim Mattson <jmattson@google.com>
virt/kvm/kvm_main.c

index 2799c66..b9f12da 100644 (file)
@@ -2973,7 +2973,8 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
                                goto out;
                        }
                        poll_end = cur = ktime_get();
-               } while (single_task_running() && ktime_before(cur, stop));
+               } while (single_task_running() && !need_resched() &&
+                        ktime_before(cur, stop));
        }
 
        prepare_to_rcuwait(&vcpu->wait);