playsink: fix video when subtitles disabled
authorWim Taymans <wim.taymans@collabora.co.uk>
Wed, 9 Dec 2009 11:10:35 +0000 (12:10 +0100)
committerWim Taymans <wim.taymans@collabora.co.uk>
Wed, 9 Dec 2009 11:11:55 +0000 (12:11 +0100)
When we have a source with subtitles but they were disabled with the flags,
still ghostpad the video pad instead of leaving it unlinked.

gst/playback/gstplaysink.c

index 2cbfc1f..e5755f7 100644 (file)
@@ -1749,6 +1749,8 @@ gst_play_sink_reconfigure (GstPlaySink * playsink)
       }
     }
   }
+  GST_DEBUG_OBJECT (playsink, "audio:%d, video:%d, vis:%d, text:%d", need_audio,
+      need_video, need_vis, need_text);
 
   /* set up video pipeline */
   if (need_video) {
@@ -1784,7 +1786,7 @@ gst_play_sink_reconfigure (GstPlaySink * playsink)
       add_chain (GST_PLAY_CHAIN (playsink->videochain), TRUE);
       activate_chain (GST_PLAY_CHAIN (playsink->videochain), TRUE);
       /* if we are not part of vis or subtitles, set the ghostpad target */
-      if (!need_vis && !need_text && playsink->text_pad == NULL) {
+      if (!need_vis && !need_text) {
         GST_DEBUG_OBJECT (playsink, "ghosting video sinkpad");
         gst_ghost_pad_set_target (GST_GHOST_PAD_CAST (playsink->video_pad),
             playsink->videochain->sinkpad);